[chromium-style] override / virtual warnings

This commit is contained in:
Jeremy Apthorp 2018-04-17 16:03:51 -07:00
parent a635f078c6
commit e6695cf2ec
62 changed files with 106 additions and 106 deletions

View file

@ -34,7 +34,7 @@ class AutoUpdater : public mate::EventEmitter<AutoUpdater>,
void OnError(const std::string& error) override;
void OnError(const std::string& message,
const int code,
const std::string& domain);
const std::string& domain) override;
void OnCheckingForUpdate() override;
void OnUpdateAvailable() override;
void OnUpdateNotAvailable() override;

View file

@ -50,7 +50,7 @@ class DownloadItem : public mate::TrackableObject<DownloadItem>,
protected:
DownloadItem(v8::Isolate* isolate, content::DownloadItem* download_item);
~DownloadItem();
~DownloadItem() override;
// Override content::DownloadItem::Observer methods
void OnDownloadUpdated(content::DownloadItem* download) override;

View file

@ -47,7 +47,7 @@ class Protocol : public mate::TrackableObject<Protocol> {
protected:
Protocol(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~Protocol();
~Protocol() override;
private:
// Possible errors.

View file

@ -91,7 +91,7 @@ class Session : public mate::TrackableObject<Session>,
protected:
Session(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~Session();
~Session() override;
// content::DownloadManager::Observer:
void OnDownloadCreated(content::DownloadManager* manager,

View file

@ -262,7 +262,7 @@ class WebContents : public mate::TrackableObject<WebContents>,
content::WebContents* web_contents,
Type type);
WebContents(v8::Isolate* isolate, const mate::Dictionary& options);
~WebContents();
~WebContents() override;
void InitWithSessionAndOptions(v8::Isolate* isolate,
content::WebContents* web_contents,

View file

@ -32,7 +32,7 @@ class SavePageHandler : public content::DownloadManager::Observer,
SavePageHandler(content::WebContents* web_contents,
const SavePageCallback& callback);
~SavePageHandler();
~SavePageHandler() override;
bool Handle(const base::FilePath& full_path,
const content::SavePageType& save_type);

View file

@ -31,7 +31,7 @@ class AtomBrowserClient : public brightray::BrowserClient,
public content::RenderProcessHostObserver {
public:
AtomBrowserClient();
virtual ~AtomBrowserClient();
~AtomBrowserClient() override;
using Delegate = content::ContentBrowserClient;
void set_delegate(Delegate* delegate) { delegate_ = delegate; }

View file

@ -28,7 +28,7 @@ class BridgeTaskRunner;
class AtomBrowserMainParts : public brightray::BrowserMainParts {
public:
AtomBrowserMainParts();
virtual ~AtomBrowserMainParts();
~AtomBrowserMainParts() override;
static AtomBrowserMainParts* Get();

View file

@ -22,7 +22,7 @@ class AtomDownloadManagerDelegate : public content::DownloadManagerDelegate {
base::Callback<void(const base::FilePath&)>;
explicit AtomDownloadManagerDelegate(content::DownloadManager* manager);
virtual ~AtomDownloadManagerDelegate();
~AtomDownloadManagerDelegate() override;
void OnDownloadPathGenerated(uint32_t download_id,
const content::DownloadTargetCallback& callback,

View file

@ -18,7 +18,7 @@ class AtomSpeechRecognitionManagerDelegate
public content::SpeechRecognitionEventListener {
public:
AtomSpeechRecognitionManagerDelegate();
virtual ~AtomSpeechRecognitionManagerDelegate();
~AtomSpeechRecognitionManagerDelegate() override;
// content::SpeechRecognitionEventListener:
void OnRecognitionStart(int session_id) override;

View file

@ -16,7 +16,7 @@ class AtomWebUIControllerFactory : public content::WebUIControllerFactory {
static AtomWebUIControllerFactory* GetInstance();
AtomWebUIControllerFactory();
virtual ~AtomWebUIControllerFactory();
~AtomWebUIControllerFactory() override;
// content::WebUIControllerFactory:
content::WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context,

View file

@ -38,7 +38,7 @@ class LoginHandler;
class Browser : public WindowListObserver {
public:
Browser();
~Browser();
~Browser() override;
static Browser* Get();

View file

@ -33,7 +33,7 @@ class CommonWebContentsDelegate
public brightray::InspectableWebContentsViewDelegate {
public:
CommonWebContentsDelegate();
virtual ~CommonWebContentsDelegate();
~CommonWebContentsDelegate() override;
// Creates a InspectableWebContents object and takes onwership of
// |web_contents|.

View file

@ -119,8 +119,8 @@ class NativeWindowMac : public NativeWindow {
void RefreshTouchBarItem(const std::string& item_id) override;
void SetEscapeTouchBarItem(const mate::PersistentDictionary& item) override;
gfx::Rect ContentBoundsToWindowBounds(const gfx::Rect& bounds) const;
gfx::Rect WindowBoundsToContentBounds(const gfx::Rect& bounds) const;
gfx::Rect ContentBoundsToWindowBounds(const gfx::Rect& bounds) const override;
gfx::Rect WindowBoundsToContentBounds(const gfx::Rect& bounds) const override;
// Set the attribute of NSWindow while work around a bug of zoom button.
void SetStyleMask(bool on, NSUInteger flag);

View file

@ -18,7 +18,7 @@ class AsarProtocolHandler : public net::URLRequestJobFactory::ProtocolHandler {
public:
explicit AsarProtocolHandler(
const scoped_refptr<base::TaskRunner>& file_task_runner);
virtual ~AsarProtocolHandler();
~AsarProtocolHandler() override;
// net::URLRequestJobFactory::ProtocolHandler:
net::URLRequestJob* MaybeCreateJob(

View file

@ -42,7 +42,7 @@ class URLRequestAsarJob : public net::URLRequestJob {
const base::FilePath& file_path);
protected:
virtual ~URLRequestAsarJob();
~URLRequestAsarJob() override;
void InitializeAsarJob(const scoped_refptr<base::TaskRunner> file_task_runner,
std::shared_ptr<Archive> archive,

View file

@ -31,7 +31,7 @@ struct VerifyRequestParams {
class AtomCertVerifier : public net::CertVerifier {
public:
explicit AtomCertVerifier(brightray::RequireCTDelegate* ct_delegate);
virtual ~AtomCertVerifier();
~AtomCertVerifier() override;
using VerifyProc = base::Callback<void(const VerifyRequestParams& request,
const net::CompletionCallback&)>;

View file

@ -21,7 +21,7 @@ const void* DisableProtocolInterceptFlagKey();
class AtomURLRequestJobFactory : public net::URLRequestJobFactory {
public:
AtomURLRequestJobFactory();
virtual ~AtomURLRequestJobFactory();
~AtomURLRequestJobFactory() override;
// Sets the ProtocolHandler for a scheme. Returns true on success, false on
// failure (a ProtocolHandler already exists for |scheme|). On success,

View file

@ -14,7 +14,7 @@ namespace atom {
class HttpProtocolHandler : public net::URLRequestJobFactory::ProtocolHandler {
public:
explicit HttpProtocolHandler(const std::string&);
virtual ~HttpProtocolHandler();
~HttpProtocolHandler() override;
// net::URLRequestJobFactory::ProtocolHandler:
net::URLRequestJob* MaybeCreateJob(

View file

@ -27,7 +27,7 @@ class RenderProcessPreferences : public content::NotificationObserver {
// The |predicate| is used to determine whether to set preferences for a
// render process.
explicit RenderProcessPreferences(const Predicate& predicate);
virtual ~RenderProcessPreferences();
~RenderProcessPreferences() override;
int AddEntry(const base::DictionaryValue& entry);
void RemoveEntry(int id);

View file

@ -16,7 +16,7 @@ class AtomMenuModel : public ui::SimpleMenuModel {
public:
class Delegate : public ui::SimpleMenuModel::Delegate {
public:
virtual ~Delegate() {}
~Delegate() override {}
virtual bool GetAcceleratorForCommandIdWithParams(
int command_id,
@ -44,7 +44,7 @@ class AtomMenuModel : public ui::SimpleMenuModel {
};
explicit AtomMenuModel(Delegate* delegate);
virtual ~AtomMenuModel();
~AtomMenuModel() override;
void AddObserver(Observer* obs) { observers_.AddObserver(obs); }
void RemoveObserver(Observer* obs) { observers_.RemoveObserver(obs); }

View file

@ -21,7 +21,7 @@ class AutofillPopupView;
class AutofillPopup : public views::ViewObserver {
public:
AutofillPopup();
~AutofillPopup();
~AutofillPopup() override;
void CreateView(content::RenderFrameHost* render_frame,
bool offscreen,

View file

@ -20,7 +20,7 @@ namespace atom {
class TrayIconCocoa : public TrayIcon, public AtomMenuModel::Observer {
public:
TrayIconCocoa();
virtual ~TrayIconCocoa();
~TrayIconCocoa() override;
void SetImage(const gfx::Image& image) override;
void SetPressedImage(const gfx::Image& image) override;