refactor: declare gin::Wrapper subclasses as final (#43783)
refactor: declare gin::Wrapper subclasses as final (#43527) As per the gin docs: "Wrappable<T> explicitly does not support further subclassing of T. Subclasses of Wrappable<T> should be declared final."
This commit is contained in:
parent
ea3c48e7c1
commit
e62c322b2d
35 changed files with 106 additions and 103 deletions
|
@ -43,7 +43,7 @@ class Arguments;
|
|||
|
||||
namespace electron::api {
|
||||
|
||||
class NativeImage : public gin::Wrappable<NativeImage> {
|
||||
class NativeImage final : public gin::Wrappable<NativeImage> {
|
||||
public:
|
||||
NativeImage(v8::Isolate* isolate, const gfx::Image& image);
|
||||
#if BUILDFLAG(IS_WIN)
|
||||
|
|
|
@ -160,8 +160,9 @@ class BufferDataSource : public mojo::DataPipeProducer::DataSource {
|
|||
std::vector<char> buffer_;
|
||||
};
|
||||
|
||||
class JSChunkedDataPipeGetter : public gin::Wrappable<JSChunkedDataPipeGetter>,
|
||||
public network::mojom::ChunkedDataPipeGetter {
|
||||
class JSChunkedDataPipeGetter final
|
||||
: public gin::Wrappable<JSChunkedDataPipeGetter>,
|
||||
public network::mojom::ChunkedDataPipeGetter {
|
||||
public:
|
||||
static gin::Handle<JSChunkedDataPipeGetter> Create(
|
||||
v8::Isolate* isolate,
|
||||
|
|
|
@ -43,7 +43,7 @@ class ElectronBrowserContext;
|
|||
namespace electron::api {
|
||||
|
||||
/** Wraps a SimpleURLLoader to make it usable from JavaScript */
|
||||
class SimpleURLLoaderWrapper
|
||||
class SimpleURLLoaderWrapper final
|
||||
: public gin::Wrappable<SimpleURLLoaderWrapper>,
|
||||
public gin_helper::EventEmitterMixin<SimpleURLLoaderWrapper>,
|
||||
public network::SimpleURLLoaderStreamConsumer,
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue