mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: move window.open postMessage test to main runner to fix flake (#18735)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-06-11 16:35:58 -07:00 • committed by Cheng Zhao
parent 81ad355355
commit e5d1e7b4da
5 changed files with 35 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

21
spec/chromium-spec.js
View file

@ -721,27 +721,6 @@ describe('chromium feature', () => {
})
describe('window.postMessage', () => {
it('sets the source and origin correctly', (done) => {
let b = null
listener = (event) => {
window.removeEventListener('message', listener)
b.close()
const message = JSON.parse(event.data)
expect(message.data).to.equal('testing')
expect(message.origin).to.equal('file://')
expect(message.sourceEqualsOpener).to.be.true()
expect(event.origin).to.equal('file://')
done()
}
window.addEventListener('message', listener)
app.once('browser-window-created', (event, { webContents }) => {
webContents.once('did-finish-load', () => {
b.postMessage('testing', '*')
})
})
b = window.open(`file://${fixtures}/pages/window-open-postMessage.html`, '', 'show=no')
})
it('throws an exception when the targetOrigin cannot be converted to a string', () => {
const b = window.open('')
expect(() => {