From e56adafc1fa496cfe4ebdbad84726424963d2d56 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Wed, 22 May 2019 11:42:24 -0700 Subject: [PATCH] disable robotjs-based tests See #18409 --- spec/api-menu-spec.js | 4 +++- spec/api-web-contents-spec.js | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/spec/api-menu-spec.js b/spec/api-menu-spec.js index 720c45b988c6..127b5fda9007 100644 --- a/spec/api-menu-spec.js +++ b/spec/api-menu-spec.js @@ -835,7 +835,9 @@ describe('Menu module', () => { }) }) - describe('menu accelerators', () => { + // FIXME(nornagon): this is disabled due to an issue with nan in current v8. + // See https://github.com/electron/electron/issues/18409 + describe.skip('menu accelerators', () => { let testFn = it try { // We have other tests that check if native modules work, if we fail to require diff --git a/spec/api-web-contents-spec.js b/spec/api-web-contents-spec.js index 5dd3ed1e5522..13298badbd9d 100644 --- a/spec/api-web-contents-spec.js +++ b/spec/api-web-contents-spec.js @@ -382,7 +382,9 @@ describe('webContents module', () => { }) }) - describe('devtools window', () => { + // FIXME(nornagon): this is disabled due to an issue with nan in current v8. + // See https://github.com/electron/electron/issues/18409 + describe.skip('devtools window', () => { let testFn = it if (process.platform === 'darwin' && isCi) { testFn = it.skip