mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: move gin::Handle to gin_helper (#48016)

Browse source 
chore: move gin::Handle to gin_helper (#47959)

* chore: move gin::Handle to gin_helper

* chore: fix lint

Co-authored-by: Robo <hop2deep@gmail.com>
This commit is contained in:
Calvin 2025-08-10 13:46:37 -06:00 • committed by GitHub
commit e3f358a45a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
95 changed files with 555 additions and 419 deletions
Download patch file Download diff file Expand all files Collapse all files

13
shell/browser/api/electron_api_view.h
View file

@ -14,10 +14,10 @@
#include "ui/views/view_observer.h"
#include "v8/include/v8-value.h"
namespace gin {
namespace gin_helper {
template <typename T>
class Handle;
} // namespace gin
} // namespace gin_helper
namespace electron::api {
@ -25,7 +25,7 @@ class View : public gin_helper::EventEmitter<View>,
private views::ViewObserver {
public:
static gin_helper::WrappableBase* New(gin::Arguments* args);
static gin::Handle<View> Create(v8::Isolate* isolate);
static gin_helper::Handle<View> Create(v8::Isolate* isolate);
// Return the cached constructor function.
static v8::Local<v8::Function> GetConstructor(v8::Isolate* isolate);
@ -33,8 +33,9 @@ class View : public gin_helper::EventEmitter<View>,
static void BuildPrototype(v8::Isolate* isolate,
v8::Local<v8::FunctionTemplate> prototype);
void AddChildViewAt(gin::Handle<View> child, std::optional<size_t> index);
void RemoveChildView(gin::Handle<View> child);
void AddChildViewAt(gin_helper::Handle<View> child,
std::optional<size_t> index);
void RemoveChildView(gin_helper::Handle<View> child);
void SetBounds(const gfx::Rect& bounds);
gfx::Rect GetBounds() const;
@ -70,7 +71,7 @@ class View : public gin_helper::EventEmitter<View>,
views::View* child) override;
void ApplyBorderRadius();
void ReorderChildView(gin::Handle<View> child, size_t index);
void ReorderChildView(gin_helper::Handle<View> child, size_t index);
std::vector<ChildPair> child_views_;
std::optional<int> border_radius_;