mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: silence -Wunsafe-buffer-usage warning in GetPreferredLanguages() (#44333)

Browse source 
fix: use UNSAFE_BUFFERS macro in GetPreferredLanguages()
This commit is contained in:
Charles Kerr 2024-10-21 18:20:00 -05:00 committed by GitHub
parent fff6ea438a
commit e3e94d45ee
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
shell/common/language_util_linux.cc
View file

@ -22,7 +22,10 @@ std::vector<std::string> GetPreferredLanguages() {
DCHECK(languages); // A valid pointer is guaranteed. DCHECK(languages); // A valid pointer is guaranteed.
DCHECK(*languages); // At least one entry, "C", is guaranteed. DCHECK(*languages); // At least one entry, "C", is guaranteed.
for (; *languages; ++languages) { // SAFETY: |g_get_language_names()| returns a glib-owned array
// of const C strings, terminated by an empty string.
// This loop is the correct way to walk through its return values.
for (; *languages; UNSAFE_BUFFERS(++languages)) {
if (strcmp(*languages, "C") != 0) { if (strcmp(*languages, "C") != 0) {
preferredLanguages.push_back(base::i18n::GetCanonicalLocale(*languages)); preferredLanguages.push_back(base::i18n::GetCanonicalLocale(*languages));
} }