mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Remove type parameter

Browse source
This commit is contained in:
Paul Betts 2016-03-14 19:48:40 -07:00
parent 63d9174822
commit e3e6cd6fd8
1 changed files with 4 additions and 46 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
atom/common/api/atom_api_native_image.cc
View file

@ -58,20 +58,6 @@ ScaleFactorPair kScaleFactorPairs[] = {
{ "@2.5x" , 2.5f },
};
enum NativeRepresentation {
INVALID = 0,
AS_NSIMAGE,
};
struct NativeRepresentationPair {
const char* name;
NativeRepresentation rep;
};
NativeRepresentationPair kNativeRepresentations[] {
{ "nsimage", NativeRepresentation::AS_NSIMAGE },
};
float GetScaleFactorFromPath(const base::FilePath& path) {
std::string filename(path.BaseName().RemoveExtension().AsUTF8Unsafe());
@ -240,40 +226,12 @@ std::string NativeImage::ToDataURL() {
v8::Local<v8::Value> NativeImage::AsNativeRepresentation(
v8::Isolate* isolate,
mate::Arguments* args) {
NativeRepresentation desiredRep = NativeRepresentation::INVALID;
void* ptr = nullptr;
std::string type;
if (!args->GetNext(&type)) {
args->ThrowError();
goto out;
}
for (const NativeRepresentationPair& item : kNativeRepresentations) {
if (type.compare(item.name) == 0) {
desiredRep = item.rep;
break;
}
}
if (desiredRep == NativeRepresentation::INVALID) {
args->ThrowError();
goto out;
}
switch (desiredRep) {
#if defined(OS_MACOSX)
case NativeRepresentation::AS_NSIMAGE:
ptr = reinterpret_cast<void*>(image_.AsNSImage());
break;
void* ptr = reinterpret_cast<void*>(image_.AsNSImage());
#else
args.ThrowError();
return v8::Undefined(isolate);
#endif
case NativeRepresentation::INVALID:
default:
args->ThrowError();
break;
}
out:
return node::Buffer::Copy(
isolate,