mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix a bug that caused a crash when using an offscreen window with detached devtools, related to autofill popups

Browse source
This commit is contained in:
Heilig Benedek 2017-09-10 22:24:54 +02:00 • committed by Cheng Zhao
parent 5daaff91ea
commit e39aacb30e
6 changed files with 31 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
atom/browser/ui/views/autofill_popup_view.cc
View file

@ -226,12 +226,13 @@ void AutofillPopupView::OnPaint(gfx::Canvas* canvas) {
SkBitmap bitmap;
#if defined(ENABLE_OSR)
cc::SkiaPaintCanvas* paint_canvas = nullptr;
if (view_proxy_.get()) {
bitmap.allocN32Pixels(popup_->popup_bounds_in_view_.width(),
popup_->popup_bounds_in_view_.height(),
true);
cc::SkiaPaintCanvas paint_canvas(new SkCanvas(bitmap));
draw_canvas = new gfx::Canvas(&paint_canvas, 1.0);
paint_canvas = new cc::SkiaPaintCanvas(bitmap);
draw_canvas = new gfx::Canvas(paint_canvas, 1.0);
}
#endif
@ -249,6 +250,7 @@ void AutofillPopupView::OnPaint(gfx::Canvas* canvas) {
if (view_proxy_.get()) {
view_proxy_->SetBounds(popup_->popup_bounds_in_view_);
view_proxy_->SetBitmap(bitmap);
delete paint_canvas;
}
#endif
}