mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: stop menu minimization if set false (#46279)

Browse source
This commit is contained in:
Michaela Laurencin 2025-04-22 04:58:30 -04:00 • committed by GitHub
parent 274b148554
commit e383eaa465
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 20 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/browser/api/menu-item-roles.ts
View file

@ -78,7 +78,9 @@ export const roleList: Record<RoleId, Role> = {
minimize: {
label: 'Minimize',
accelerator: 'CommandOrControl+M',
windowMethod: w => w.minimize()
windowMethod: w => {
if (w.minimizable) w.minimize();
}
},
paste: {
label: 'Paste',

18
spec/api-menu-item-spec.ts
View file

@ -2,7 +2,7 @@ import { BrowserWindow, app, Menu, MenuItem, MenuItemConstructorOptions } from '
import { expect } from 'chai';
import { ifdescribe } from './lib/spec-helpers';
import { ifit, ifdescribe } from './lib/spec-helpers';
import { closeAllWindows } from './lib/window-helpers';
import { roleList, execute } from '../lib/browser/api/menu-item-roles';
@ -205,6 +205,22 @@ describe('MenuItems', () => {
const canExecute = execute(item.role as any, win, win.webContents);
expect(canExecute).to.be.true('can execute');
});
ifit(process.platform === 'win32')('does not execute minimize role when minimizable false', () => {
const win = new BrowserWindow({ minimizable: false });
const menu = Menu.buildFromTemplate([{
label: 'text',
role: 'minimize'
}]);
Menu.setApplicationMenu(menu);
menu._executeCommand({}, menu.items[0].commandId);
expect(win.isMinimized()).to.equal(false);
win.setMinimizable(true);
menu._executeCommand({}, menu.items[0].commandId);
expect(win.isMinimized()).to.equal(true);
});
});
describe('MenuItem command id', () => {