mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: custom spell-checker stuck in infinite loop (#45001)

Browse source 
`ReadUnicodeCharacter` updates index to the last character read, and not after it. We need to manually increment it to move to the next character.

It also doesn't validate that the index is valid, so we need to check that index is within bounds.

Refs: #44336
This commit is contained in:
Jesper Ek 2024-12-13 17:47:29 +01:00 • committed by GitHub
commit e2e71502b1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/renderer/api/electron_api_spell_check_client.cc
View file

@ -32,7 +32,9 @@ namespace {
bool HasWordCharacters(const std::u16string& text, size_t index) { bool HasWordCharacters(const std::u16string& text, size_t index) {
base_icu::UChar32 code; base_icu::UChar32 code;
while (base::ReadUnicodeCharacter(text.c_str(), text.size(), &index, &code)) { while (index < text.size() &&
base::ReadUnicodeCharacter(text.c_str(), text.size(), &index, &code)) {
++index;
UErrorCode error = U_ZERO_ERROR; UErrorCode error = U_ZERO_ERROR;
if (uscript_getScript(code, &error) != USCRIPT_COMMON) if (uscript_getScript(code, &error) != USCRIPT_COMMON)
return true; return true;