perf: avoid protocol registry redundant lookup (#41991)
* perf: avoid redundant map lookup in SimpleURLLoaderWrapper::GetURLLoaderFactoryForURL() * perf: avoid redundant map lookup in InspectableWebContents::LoadNetworkResource() * refactor: remove unused ProtocolRegistry::IsProtocolRegistered() refactor: remove unused ProtocolRegistry::IsProtocolIntercepted() * refactor: remove unused ProtocolRegistry::handlers() * refactor: rename ProtocolRegistry::FindIntercepted() refactor: rename ProtocolRegistry::FindRegistered() similar semantics to base::Value::Find*() * chore: follow Google C++ brace style chore: use same variable names as in main
This commit is contained in:
parent
865b0499bb
commit
e2acdffe58
5 changed files with 54 additions and 52 deletions
|
@ -674,7 +674,7 @@ void InspectableWebContents::LoadNetworkResource(DispatchCallback callback,
|
|||
resource_request.site_for_cookies = net::SiteForCookies::FromUrl(gurl);
|
||||
resource_request.headers.AddHeadersFromString(headers);
|
||||
|
||||
auto* protocol_registry = ProtocolRegistry::FromBrowserContext(
|
||||
const auto* const protocol_registry = ProtocolRegistry::FromBrowserContext(
|
||||
GetDevToolsWebContents()->GetBrowserContext());
|
||||
NetworkResourceLoader::URLLoaderFactoryHolder url_loader_factory;
|
||||
if (gurl.SchemeIsFile()) {
|
||||
|
@ -683,14 +683,12 @@ void InspectableWebContents::LoadNetworkResource(DispatchCallback callback,
|
|||
url_loader_factory = network::SharedURLLoaderFactory::Create(
|
||||
std::make_unique<network::WrapperPendingSharedURLLoaderFactory>(
|
||||
std::move(pending_remote)));
|
||||
} else if (protocol_registry->IsProtocolRegistered(gurl.scheme())) {
|
||||
auto& protocol_handler = protocol_registry->handlers().at(gurl.scheme());
|
||||
mojo::PendingRemote<network::mojom::URLLoaderFactory> pending_remote =
|
||||
ElectronURLLoaderFactory::Create(protocol_handler.first,
|
||||
protocol_handler.second);
|
||||
} else if (const auto* const protocol_handler =
|
||||
protocol_registry->FindRegistered(gurl.scheme())) {
|
||||
url_loader_factory = network::SharedURLLoaderFactory::Create(
|
||||
std::make_unique<network::WrapperPendingSharedURLLoaderFactory>(
|
||||
std::move(pending_remote)));
|
||||
ElectronURLLoaderFactory::Create(protocol_handler->first,
|
||||
protocol_handler->second)));
|
||||
} else {
|
||||
auto* partition = GetDevToolsWebContents()
|
||||
->GetBrowserContext()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue