modify CertVerifier Class

* respond to multiple similar verification requests.
* accept net error result as callback response.
This commit is contained in:
Greg Nolle 2016-11-09 13:05:46 +00:00 committed by Kevin Sawicki
parent d00a96ce35
commit e29b64a18a
8 changed files with 199 additions and 33 deletions

View file

@ -1,5 +1,5 @@
const {EventEmitter} = require('events')
const {app} = require('electron')
const {app, deprecate} = require('electron')
const {fromPartition, Session, Cookies} = process.atomBinding('session')
// Public API.
@ -20,3 +20,22 @@ Object.setPrototypeOf(Cookies.prototype, EventEmitter.prototype)
Session.prototype._init = function () {
app.emit('session-created', this)
}
// Remove after 2.0
Session.prototype.setCertificateVerifyProc = function (verifyProc) {
if (!verifyProc) {
this._setCertificateVerifyProc(null)
return
}
if (verifyProc.length <= 3) {
deprecate.warn('setCertificateVerifyproc(hostname, certificate, callback)',
'setCertificateVerifyproc(hostname, certificate, error, callback)')
this._setCertificateVerifyProc((hostname, certificate, error, cb) => {
verifyProc(hostname, certificate, (result) => {
cb(result ? 0 : -2)
})
})
} else {
this._setCertificateVerifyProc(verifyProc)
}
}