mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Revert: electron/electron#14487 (#19011)

Browse source
This commit is contained in:
Alexandre Lacheze 2019-07-12 00:25:27 +02:00 • committed by John Kleinschmidt
parent 75a020e0ac
commit e26f366405
6 changed files with 3 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/renderer/web-view/guest-view-internal.ts
View file

@ -100,10 +100,6 @@ export function createGuestSync (params: Record<string, any>): number {
return invokeSync('ELECTRON_GUEST_VIEW_MANAGER_CREATE_GUEST', params)
}
export function destroyGuest (guestInstanceId: number): void {
invoke('ELECTRON_GUEST_VIEW_MANAGER_DESTROY_GUEST', guestInstanceId)
}
export function attachGuest (
elementInstanceId: number, guestInstanceId: number, params: Record<string, any>, contentWindow: Window
) {
@ -118,6 +114,5 @@ export const guestViewInternalModule = {
deregisterEvents,
createGuest,
createGuestSync,
destroyGuest,
attachGuest
}

1
lib/renderer/web-view/web-view-impl.ts
View file

@ -69,7 +69,6 @@ export class WebViewImpl {
// heard back from createGuest yet. We will not reset the flag in this case so
// that we don't end up allocating a second guest.
if (this.guestInstanceId) {
guestViewInternal.destroyGuest(this.guestInstanceId)
this.guestInstanceId = void 0
}