From e0a24f08a1d0e64f095920f285f39a9112e585e4 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Thu, 3 Apr 2025 20:30:41 -0500 Subject: [PATCH] perf: avoid redundant map lookup in `HidChooserContext::DeviceChanged()` (#46479) perf: avoid redundant map lookup in HidChooserContext::DeviceChanged() Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- shell/browser/hid/hid_chooser_context.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/shell/browser/hid/hid_chooser_context.cc b/shell/browser/hid/hid_chooser_context.cc index 6e288fa19e5..4869f56eb8d 100644 --- a/shell/browser/hid/hid_chooser_context.cc +++ b/shell/browser/hid/hid_chooser_context.cc @@ -274,10 +274,11 @@ void HidChooserContext::DeviceRemoved(device::mojom::HidDeviceInfoPtr device) { void HidChooserContext::DeviceChanged(device::mojom::HidDeviceInfoPtr device) { DCHECK(device); - DCHECK(devices_.contains(device->guid)); // Update the device list. - devices_[device->guid] = device->Clone(); + auto& mapped = devices_[device->guid]; + DCHECK(!mapped.is_null()); + mapped = device->Clone(); // Notify all observers. for (auto& observer : device_observer_list_)