mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Merge pull request #4840 from atom/undefined-menu-accelerator

Browse source 
Undefined menu accelerator
This commit is contained in:
Cheng Zhao 2016-03-21 21:02:44 +09:00
commit e08b48ab48
2 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

15
spec/api-menu-spec.js
View file

@ -32,6 +32,21 @@ describe('menu module', function() {
]);
});
it('does not throw exceptions for undefined/null values', function() {
assert.doesNotThrow(function() {
Menu.buildFromTemplate([
{
label: 'text',
accelerator: undefined
},
{
label: 'text again',
accelerator: null
}
]);
});
});
describe('Menu.buildFromTemplate should reorder based on item position specifiers', function() {
it('should position before existing item', function() {
var menu = Menu.buildFromTemplate([