mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

chore: remove dead code in menu controller (#14939)

Browse source
This commit is contained in:
Shelley Vohr 2018-10-03 00:24:28 -07:00 committed by Cheng Zhao
parent a1b2162563
commit e06bc311a9
1 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
atom/browser/ui/cocoa/atom_menu_controller.mm
View file

@ -279,18 +279,10 @@ static base::scoped_nsobject<NSMenu> recentDocumentsMenuSwap_;
if (model) { if (model) {
BOOL checked = model->IsItemCheckedAt(modelIndex); BOOL checked = model->IsItemCheckedAt(modelIndex);
DCHECK([(id)item isKindOfClass:[NSMenuItem class]]); DCHECK([(id)item isKindOfClass:[NSMenuItem class]]);
[(id)item setState:(checked ? NSOnState : NSOffState)]; [(id)item setState:(checked ? NSOnState : NSOffState)];
[(id)item setHidden:(!model->IsVisibleAt(modelIndex))]; [(id)item setHidden:(!model->IsVisibleAt(modelIndex))];
if (model->IsItemDynamicAt(modelIndex)) {
// Update the label and the icon.
NSString* label =
l10n_util::FixUpWindowsStyleLabel(model->GetLabelAt(modelIndex));
[(id)item setTitle:label];
gfx::Image icon;
model->GetIconAt(modelIndex, &icon);
[(id)item setImage:icon.IsEmpty() ? nil : icon.ToNSImage()];
}
return model->IsEnabledAt(modelIndex); return model->IsEnabledAt(modelIndex);
} }
return NO; return NO;