diff --git a/atom/browser/api/atom_api_dialog.cc b/atom/browser/api/atom_api_dialog.cc index e8c1ae3ba99f..0ec9f1905806 100644 --- a/atom/browser/api/atom_api_dialog.cc +++ b/atom/browser/api/atom_api_dialog.cc @@ -55,12 +55,13 @@ void ShowMessageBox(int type, if (mate::Converter::FromV8(args->isolate(), peek, &callback)) { - atom::ShowMessageBox(window, (atom::MessageBoxType)type, buttons, default_button_index, - cancel_id, options, title, message, detail, icon, callback); + atom::ShowMessageBox(window, (atom::MessageBoxType)type, buttons, + default_button_index, cancel_id, options, title, + message, detail, icon, callback); } else { int chosen = atom::ShowMessageBox(window, (atom::MessageBoxType)type, - buttons, default_button_index, cancel_id, options, title, - message, detail, icon); + buttons, default_button_index, cancel_id, + options, title, message, detail, icon); args->Return(chosen); } } diff --git a/atom/browser/ui/message_box_gtk.cc b/atom/browser/ui/message_box_gtk.cc index 65f557901fd0..cf227d4e672f 100644 --- a/atom/browser/ui/message_box_gtk.cc +++ b/atom/browser/ui/message_box_gtk.cc @@ -176,8 +176,8 @@ int ShowMessageBox(NativeWindow* parent, const std::string& message, const std::string& detail, const gfx::ImageSkia& icon) { - return GtkMessageBox(parent, type, buttons, default_button_index, cancel_id, title, message, detail, - icon).RunSynchronous(); + return GtkMessageBox(parent, type, buttons, default_button_index, cancel_id, + title, message, detail, icon).RunSynchronous(); } void ShowMessageBox(NativeWindow* parent, @@ -191,8 +191,8 @@ void ShowMessageBox(NativeWindow* parent, const std::string& detail, const gfx::ImageSkia& icon, const MessageBoxCallback& callback) { - (new GtkMessageBox(parent, type, buttons, default_button_index, cancel_id, title, message, detail, - icon))->RunAsynchronous(callback); + (new GtkMessageBox(parent, type, buttons, default_button_index, cancel_id, + title, message, detail, icon))->RunAsynchronous(callback); } void ShowErrorBox(const base::string16& title, const base::string16& content) { diff --git a/atom/browser/ui/message_box_win.cc b/atom/browser/ui/message_box_win.cc index 656be9f10bb2..7ee72e64d2f2 100644 --- a/atom/browser/ui/message_box_win.cc +++ b/atom/browser/ui/message_box_win.cc @@ -72,6 +72,7 @@ void MapToCommonID(const std::vector& buttons, int ShowMessageBoxUTF16(HWND parent, MessageBoxType type, const std::vector& buttons, + int default_button_index, int cancel_id, int options, const base::string16& title, @@ -156,6 +157,7 @@ void RunMessageBoxInNewThread(base::Thread* thread, NativeWindow* parent, MessageBoxType type, const std::vector& buttons, + int default_button_index, int cancel_id, int options, const std::string& title, @@ -163,8 +165,8 @@ void RunMessageBoxInNewThread(base::Thread* thread, const std::string& detail, const gfx::ImageSkia& icon, const MessageBoxCallback& callback) { - int result = ShowMessageBox(parent, type, buttons, cancel_id, options, title, - message, detail, icon); + int result = ShowMessageBox(parent, type, buttons, default_button_index, + cancel_id, options, title, message, detail, icon); content::BrowserThread::PostTask( content::BrowserThread::UI, FROM_HERE, base::Bind(callback, result)); content::BrowserThread::DeleteSoon( @@ -176,6 +178,7 @@ void RunMessageBoxInNewThread(base::Thread* thread, int ShowMessageBox(NativeWindow* parent, MessageBoxType type, const std::vector& buttons, + int default_button_index, int cancel_id, int options, const std::string& title, @@ -194,6 +197,7 @@ int ShowMessageBox(NativeWindow* parent, return ShowMessageBoxUTF16(hwnd_parent, type, utf16_buttons, + default_button_index, cancel_id, options, base::UTF8ToUTF16(title), @@ -205,6 +209,7 @@ int ShowMessageBox(NativeWindow* parent, void ShowMessageBox(NativeWindow* parent, MessageBoxType type, const std::vector& buttons, + int default_button_index, int cancel_id, int options, const std::string& title, @@ -224,13 +229,13 @@ void ShowMessageBox(NativeWindow* parent, unretained->message_loop()->PostTask( FROM_HERE, base::Bind(&RunMessageBoxInNewThread, base::Unretained(unretained), - parent, type, buttons, cancel_id, options, title, message, - detail, icon, callback)); + parent, type, buttons, default_button_index, + cancel_id, options, title, message, detail, icon, callback)); } void ShowErrorBox(const base::string16& title, const base::string16& content) { - ShowMessageBoxUTF16(NULL, MESSAGE_BOX_TYPE_ERROR, {}, 0, 0, L"Error", title, - content, gfx::ImageSkia()); + ShowMessageBoxUTF16(NULL, MESSAGE_BOX_TYPE_ERROR, {}, -1, 0, 0, L"Error", + title, content, gfx::ImageSkia()); } } // namespace atom