mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Add a test for webcontents.printerList.

Browse source
This commit is contained in:
renaesop 2017-05-09 10:38:03 +08:00
parent cba5e96496
commit dfcc882dcc
2 changed files with 21 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
atom/browser/api/atom_api_web_contents.cc
View file

@ -1282,10 +1282,10 @@ void WebContents::Print(mate::Arguments* args) {
std::vector<printing::PrinterBasicInfo> WebContents::GetPrinterList(
mate::Arguments* args) {
std::vector<printing::PrinterBasicInfo> printerList;
auto printBackend = printing::PrintBackend::CreateInstance(nullptr);
printBackend->EnumeratePrinters(&printerList);
return printerList;
std::vector<printing::PrinterBasicInfo> printers;
auto print_backend = printing::PrintBackend::CreateInstance(nullptr);
print_backend->EnumeratePrinters(&printers);
return printers;
}
void WebContents::PrintToPDF(const base::DictionaryValue& setting,

17
spec/api-browser-window-spec.js
View file

@ -1114,6 +1114,23 @@ describe('BrowserWindow module', function () {
})
})
it('can get printer list', function (done) {
w.destroy()
w = new BrowserWindow({
show: false,
webPreferences: {
sandbox: true,
preload: preload
}
})
w.loadURL('data:text/html,%3Ch1%3EHello%2C%20World!%3C%2Fh1%3E')
w.webContents.once('did-finish-load', function () {
const pl = w.webContents.printerList()
assert.equal(Array.isArray(pl), true)
done()
})
})
it('can print to PDF', function (done) {
w.destroy()
w = new BrowserWindow({