mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: use v8::Local<>, not v8::Handle<> (#43019)

Browse source 
v8::Handle is an alias for v8::Local that "is kept around for historical
reasons" and is disabled when V8_IMMINENT_DEPRECATION_WARNING is defined
This commit is contained in:
Charles Kerr 2024-07-24 18:24:07 -05:00 • committed by GitHub
parent 5669a40d5c
commit df524c6eca
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
15 changed files with 34 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/common/node_bindings.cc
View file

@ -577,7 +577,7 @@ void NodeBindings::Initialize(v8::Local<v8::Context> context) {
}
std::shared_ptr<node::Environment> NodeBindings::CreateEnvironment(
v8::Handle<v8::Context> context,
v8::Local<v8::Context> context,
node::MultiIsolatePlatform* platform,
std::vector<std::string> args,
std::vector<std::string> exec_args,
@ -779,7 +779,7 @@ std::shared_ptr<node::Environment> NodeBindings::CreateEnvironment(
}
std::shared_ptr<node::Environment> NodeBindings::CreateEnvironment(
v8::Handle<v8::Context> context,
v8::Local<v8::Context> context,
node::MultiIsolatePlatform* platform,
std::optional<base::RepeatingCallback<void()>> on_app_code_ready) {
#if BUILDFLAG(IS_WIN)