From de893360f7c320c089805eeb1948c50938b0a13d Mon Sep 17 00:00:00 2001 From: Shelley Vohr Date: Wed, 8 Apr 2020 12:47:43 -0700 Subject: [PATCH] fix: missing HandleScope in OnDownloadPathGenerated (#23005) --- shell/browser/electron_download_manager_delegate.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/shell/browser/electron_download_manager_delegate.cc b/shell/browser/electron_download_manager_delegate.cc index f322c7788412..dbb034a3ced6 100644 --- a/shell/browser/electron_download_manager_delegate.cc +++ b/shell/browser/electron_download_manager_delegate.cc @@ -117,6 +117,7 @@ void ElectronDownloadManagerDelegate::OnDownloadPathGenerated( settings.force_detached = offscreen; v8::Isolate* isolate = v8::Isolate::GetCurrent(); + v8::HandleScope scope(isolate); gin_helper::Promise dialog_promise(isolate); auto dialog_callback = base::BindOnce( &ElectronDownloadManagerDelegate::OnDownloadSaveDialogDone,