mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: promisify webContents.savePage() (#16742)

Browse source 
* feat: promisify webContents.savePage()

* no need to make compatible w callbacks, we're breaking it

* fix promise resolve type

* address feedback from review

* fix promise return text

* update smoke test
This commit is contained in:
Shelley Vohr 2019-02-14 09:03:28 -08:00 • committed by GitHub
parent 6e7dca9082
commit de27911661
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 35 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

7
atom/browser/api/save_page_handler.h
View file

@ -7,6 +7,7 @@
#include <string>
#include "atom/common/promise_util.h"
#include "components/download/public/common/download_item.h"
#include "content/public/browser/download_manager.h"
#include "content/public/browser/save_page_type.h"
@ -28,10 +29,8 @@ namespace api {
class SavePageHandler : public content::DownloadManager::Observer,
public download::DownloadItem::Observer {
public:
using SavePageCallback = base::Callback<void(v8::Local<v8::Value>)>;
SavePageHandler(content::WebContents* web_contents,
const SavePageCallback& callback);
scoped_refptr<atom::util::Promise> promise);
~SavePageHandler() override;
bool Handle(const base::FilePath& full_path,
@ -48,7 +47,7 @@ class SavePageHandler : public content::DownloadManager::Observer,
void OnDownloadUpdated(download::DownloadItem* item) override;
content::WebContents* web_contents_; // weak
SavePageCallback callback_;
scoped_refptr<atom::util::Promise> promise_;
};
} // namespace api