mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use C++11 class member variable initialization (#27477)

Browse source
This commit is contained in:
Milan Burda 2021-01-26 19:16:21 +01:00 • committed by GitHub
parent f083380c38
commit ddf3ef0a5f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
93 changed files with 130 additions and 163 deletions
Download patch file Download diff file Expand all files Collapse all files

3
shell/renderer/api/electron_api_spell_check_client.cc
View file

@ -73,8 +73,7 @@ class SpellCheckClient::SpellcheckRequest {
SpellCheckClient::SpellCheckClient(const std::string& language,
v8::Isolate* isolate,
v8::Local<v8::Object> provider)
: pending_request_param_(nullptr),
isolate_(isolate),
: isolate_(isolate),
context_(isolate, isolate->GetCurrentContext()),
provider_(isolate, provider) {
DCHECK(!context_.IsEmpty());

3
shell/renderer/electron_api_service_impl.cc
View file

@ -104,8 +104,7 @@ ElectronApiServiceImpl::ElectronApiServiceImpl(
content::RenderFrame* render_frame,
RendererClientBase* renderer_client)
: content::RenderFrameObserver(render_frame),
renderer_client_(renderer_client),
weak_factory_(this) {}
renderer_client_(renderer_client) {}
void ElectronApiServiceImpl::BindTo(
mojo::PendingAssociatedReceiver<mojom::ElectronRenderer> receiver) {

2
shell/renderer/electron_api_service_impl.h
View file

@ -57,7 +57,7 @@ class ElectronApiServiceImpl : public mojom::ElectronRenderer,
mojo::AssociatedReceiver<mojom::ElectronRenderer> receiver_{this};
RendererClientBase* renderer_client_;
base::WeakPtrFactory<ElectronApiServiceImpl> weak_factory_;
base::WeakPtrFactory<ElectronApiServiceImpl> weak_factory_{this};
DISALLOW_COPY_AND_ASSIGN(ElectronApiServiceImpl);
};

2
shell/renderer/electron_autofill_agent.cc
View file

@ -51,7 +51,7 @@ void TrimStringVectorForIPC(std::vector<base::string16>* strings) {
AutofillAgent::AutofillAgent(content::RenderFrame* frame,
blink::AssociatedInterfaceRegistry* registry)
: content::RenderFrameObserver(frame), weak_ptr_factory_(this) {
: content::RenderFrameObserver(frame) {
render_frame()->GetWebFrame()->SetAutofillClient(this);
registry->AddInterface(base::BindRepeating(&AutofillAgent::BindReceiver,
base::Unretained(this)));

2
shell/renderer/electron_autofill_agent.h
View file

@ -84,7 +84,7 @@ class AutofillAgent : public content::RenderFrameObserver,
mojo::AssociatedReceiver<mojom::ElectronAutofillAgent> receiver_{this};
base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_;
base::WeakPtrFactory<AutofillAgent> weak_ptr_factory_{this};
DISALLOW_COPY_AND_ASSIGN(AutofillAgent);
};

3
shell/renderer/guest_view_container.cc
View file

@ -22,8 +22,7 @@ static base::LazyInstance<GuestViewContainerMap>::DestructorAtExit
} // namespace
GuestViewContainer::GuestViewContainer(content::RenderFrame* render_frame)
: weak_ptr_factory_(this) {}
GuestViewContainer::GuestViewContainer(content::RenderFrame* render_frame) {}
GuestViewContainer::~GuestViewContainer() {
if (element_instance_id_ > 0)

2
shell/renderer/guest_view_container.h
View file

@ -32,7 +32,7 @@ class GuestViewContainer {
ResizeCallback element_resize_callback_;
base::WeakPtrFactory<GuestViewContainer> weak_ptr_factory_;
base::WeakPtrFactory<GuestViewContainer> weak_ptr_factory_{this};
DISALLOW_COPY_AND_ASSIGN(GuestViewContainer);
};