mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: use C++11 class member variable initialization (#27477)

Browse source
This commit is contained in:
Milan Burda 2021-01-26 19:16:21 +01:00 • committed by GitHub
parent f083380c38
commit ddf3ef0a5f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
93 changed files with 130 additions and 163 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/common/api/object_life_monitor.cc
View file

@ -11,7 +11,7 @@ namespace electron {
ObjectLifeMonitor::ObjectLifeMonitor(v8::Isolate* isolate,
v8::Local<v8::Object> target)
: target_(isolate, target), weak_ptr_factory_(this) {
: target_(isolate, target) {
target_.SetWeak(this, OnObjectGC, v8::WeakCallbackType::kParameter);
}

2
shell/common/api/object_life_monitor.h
View file

@ -24,7 +24,7 @@ class ObjectLifeMonitor {
v8::Global<v8::Object> target_;
base::WeakPtrFactory<ObjectLifeMonitor> weak_ptr_factory_;
base::WeakPtrFactory<ObjectLifeMonitor> weak_ptr_factory_{this};
DISALLOW_COPY_AND_ASSIGN(ObjectLifeMonitor);
};

2
shell/common/gin_helper/trackable_object.cc
View file

@ -31,7 +31,7 @@ class IDUserData : public base::SupportsUserData::Data {
} // namespace
TrackableObjectBase::TrackableObjectBase() : weak_factory_(this) {
TrackableObjectBase::TrackableObjectBase() {
// TODO(zcbenz): Make TrackedObject work in renderer process.
DCHECK(gin_helper::Locker::IsBrowserProcess())
<< "This class only works for browser process";

2
shell/common/gin_helper/trackable_object.h
View file

@ -43,7 +43,7 @@ class TrackableObjectBase {
private:
void Destroy();
base::WeakPtrFactory<TrackableObjectBase> weak_factory_;
base::WeakPtrFactory<TrackableObjectBase> weak_factory_{this};
DISALLOW_COPY_AND_ASSIGN(TrackableObjectBase);
};

2
shell/common/node_bindings.cc
View file

@ -302,7 +302,7 @@ base::FilePath GetResourcesPath() {
} // namespace
NodeBindings::NodeBindings(BrowserEnvironment browser_env)
: browser_env_(browser_env), weak_factory_(this) {
: browser_env_(browser_env) {
if (browser_env == BrowserEnvironment::kWorker) {
uv_loop_init(&worker_loop_);
uv_loop_ = &worker_loop_;

2
shell/common/node_bindings.h
View file

@ -159,7 +159,7 @@ class NodeBindings {
// Isolate data used in creating the environment
node::IsolateData* isolate_data_ = nullptr;
base::WeakPtrFactory<NodeBindings> weak_factory_;
base::WeakPtrFactory<NodeBindings> weak_factory_{this};
DISALLOW_COPY_AND_ASSIGN(NodeBindings);
};