mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Remove the memory property from getAppMetrics

Browse source 
See 03d0bfd593 for more information
This commit is contained in:
Samuel Attard 2018-07-22 00:35:41 +10:00 • committed by Aleksei Kuzmin
parent 14df89f214
commit dde194d853
5 changed files with 4 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec/api-app-spec.js
View file

@ -786,15 +786,7 @@ describe('app module', () => {
expect(appMetrics).to.be.an('array').and.have.lengthOf.at.least(1, 'App memory info object is not > 0')
const types = []
for (const {memory, pid, type, cpu} of appMetrics) {
expect(memory.workingSetSize).to.be.above(0, 'working set size is not > 0')
// windows causes failures here due to CI server configuration
if (process.platform !== 'win32') {
expect(memory.privateBytes).to.be.above(0, 'private bytes is not > 0')
expect(memory.sharedBytes).to.be.above(0, 'shared bytes is not > 0')
}
for (const {pid, type, cpu} of appMetrics) {
expect(pid).to.be.above(0, 'pid is not > 0')
expect(type).to.be.a('string').that.is.not.empty()