mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: utilityProcess pid should be undefined after exit (#44677)

Browse source 
fix: utilityProcess pid should be undefined after exit
This commit is contained in:
Shelley Vohr 2024-11-18 10:06:27 +01:00 • committed by GitHub
parent 15ff999bdc
commit dd50afa8c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 25 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

20
spec/api-utility-process-spec.ts
View file

@ -240,13 +240,31 @@ describe('utilityProcess module', () => {
it('is valid when child process launches successfully', async () => {
const child = utilityProcess.fork(path.join(fixturesPath, 'empty.js'));
await once(child, 'spawn');
expect(child.pid).to.not.be.null();
expect(child).to.have.property('pid').that.is.a('number');
});
it('is undefined when child process fails to launch', async () => {
const child = utilityProcess.fork(path.join(fixturesPath, 'does-not-exist.js'));
expect(child.pid).to.be.undefined();
});
it('is undefined before the child process is spawned succesfully', async () => {
const child = utilityProcess.fork(path.join(fixturesPath, 'empty.js'));
expect(child.pid).to.be.undefined();
await once(child, 'spawn');
child.kill();
});
it('is undefined when child process is killed', async () => {
const child = utilityProcess.fork(path.join(fixturesPath, 'empty.js'));
await once(child, 'spawn');
expect(child).to.have.property('pid').that.is.a('number');
expect(child.kill()).to.be.true();
await once(child, 'exit');
expect(child.pid).to.be.undefined();
});
});
describe('stdout property', () => {