mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

revert: test use emittedUntil in PDF Viewer tests (#27273)

Browse source 
This reverts commit 36f4ee87df.
This commit is contained in:
Milan Burda 2021-01-13 22:49:35 +01:00 • committed by GitHub
parent cd42933f41
commit dd17250a80
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec-main/chromium-spec.ts
View file

@ -1,6 +1,6 @@
import { expect } from 'chai'; import { expect } from 'chai';
import { BrowserWindow, WebContents, session, ipcMain, app, protocol, webContents } from 'electron/main'; import { BrowserWindow, WebContents, session, ipcMain, app, protocol, webContents } from 'electron/main';
import { emittedOnce, emittedUntil } from './events-helpers'; import { emittedOnce } from './events-helpers';
import { closeAllWindows } from './window-helpers'; import { closeAllWindows } from './window-helpers';
import * as https from 'https'; import * as https from 'https';
import * as http from 'http'; import * as http from 'http';
@ -1283,17 +1283,15 @@ describe('chromium features', () => {
it('opens when loading a pdf resource as top level navigation', async () => { it('opens when loading a pdf resource as top level navigation', async () => {
const w = new BrowserWindow({ show: false }); const w = new BrowserWindow({ show: false });
w.loadURL(pdfSource); w.loadURL(pdfSource);
await emittedUntil(app, 'web-contents-created', (event: Electron.Event, contents: WebContents) => { const [, contents] = await emittedOnce(app, 'web-contents-created');
return contents.getURL() === 'chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html'; expect(contents.getURL()).to.equal('chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html');
});
}); });
it('opens when loading a pdf resource in a iframe', async () => { it('opens when loading a pdf resource in a iframe', async () => {
const w = new BrowserWindow({ show: false }); const w = new BrowserWindow({ show: false });
w.loadFile(path.join(__dirname, 'fixtures', 'pages', 'pdf-in-iframe.html')); w.loadFile(path.join(__dirname, 'fixtures', 'pages', 'pdf-in-iframe.html'));
await emittedUntil(app, 'web-contents-created', (event: Electron.Event, contents: WebContents) => { const [, contents] = await emittedOnce(app, 'web-contents-created');
return contents.getURL() === 'chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html'; expect(contents.getURL()).to.equal('chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html');
});
}); });
}); });