From dcdc3621accf5d8de00d0b537c1285942e8ecddb Mon Sep 17 00:00:00 2001 From: Zhuo Lu Date: Mon, 20 Nov 2017 16:31:21 -0800 Subject: [PATCH] Rename roles --- atom/browser/ui/cocoa/atom_menu_controller.mm | 4 ++-- lib/browser/api/menu-item-roles.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/atom/browser/ui/cocoa/atom_menu_controller.mm b/atom/browser/ui/cocoa/atom_menu_controller.mm index 62745ddb42e4..e83375699030 100644 --- a/atom/browser/ui/cocoa/atom_menu_controller.mm +++ b/atom/browser/ui/cocoa/atom_menu_controller.mm @@ -50,7 +50,7 @@ Role kRolesMap[] = { { @selector(selectPreviousTab:), "selectprevioustab" }, { @selector(mergeAllWindows:), "mergeallwindows" }, { @selector(moveTabToNewWindow:), "movetabtonewwindow" }, - { @selector(clearRecentDocuments:), "clearrecent" }, + { @selector(clearRecentDocuments:), "clearrecentdocuments" }, }; } // namespace @@ -218,7 +218,7 @@ NSMenu* swapMenu_; [NSApp setHelpMenu:submenu]; else if (role == base::ASCIIToUTF16("services")) [NSApp setServicesMenu:submenu]; - else if (role == base::ASCIIToUTF16("openrecent")) + else if (role == base::ASCIIToUTF16("recentdocuments")) [self replaceSubmenuShowingRecentDocuments:item]; } else { // The MenuModel works on indexes so we can't just set the command id as the diff --git a/lib/browser/api/menu-item-roles.js b/lib/browser/api/menu-item-roles.js index 64af36c3a460..3315d0536c7c 100644 --- a/lib/browser/api/menu-item-roles.js +++ b/lib/browser/api/menu-item-roles.js @@ -102,10 +102,10 @@ const roles = { services: { label: 'Services' }, - openrecent: { + recentdocuments: { label: 'Open Recent' }, - clearrecent: { + clearrecentdocuments: { label: 'Clear Menu' }, startspeaking: {