mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Fix the cyclic reference in menu delegate (#11967)

Browse source 
* Fix the cyclic reference in menu delegate

* Fix menu tests due to delegate change
This commit is contained in:
Cheng Zhao 2018-02-21 01:11:35 +09:00 • committed by Charles Kerr
parent e1b81b8a62
commit dc62e51ba4
6 changed files with 61 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec/api-menu-spec.js
View file

@ -430,7 +430,7 @@ describe('Menu module', () => {
}
}
])
menu.delegate.executeCommand({}, menu.items[0].commandId)
menu.delegate.executeCommand(menu, {}, menu.items[0].commandId)
})
})
@ -443,7 +443,7 @@ describe('Menu module', () => {
}
])
assert.equal(menu.items[0].checked, false)
menu.delegate.executeCommand({}, menu.items[0].commandId)
menu.delegate.executeCommand(menu, {}, menu.items[0].commandId)
assert.equal(menu.items[0].checked, true)
})
@ -454,9 +454,9 @@ describe('Menu module', () => {
type: 'radio'
}
])
menu.delegate.executeCommand({}, menu.items[0].commandId)
menu.delegate.executeCommand(menu, {}, menu.items[0].commandId)
assert.equal(menu.items[0].checked, true)
menu.delegate.executeCommand({}, menu.items[0].commandId)
menu.delegate.executeCommand(menu, {}, menu.items[0].commandId)
assert.equal(menu.items[0].checked, true)
})
@ -476,7 +476,7 @@ describe('Menu module', () => {
})
}
const menu = Menu.buildFromTemplate(template)
menu.delegate.menuWillShow()
menu.delegate.menuWillShow(menu)
assert.equal(menu.items[0].checked, true)
assert.equal(menu.items[12].checked, true)
})