From dc2a6c5d71f72ab5d656fb301e3a7b541fc6a4a6 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Fri, 14 Sep 2018 19:46:53 +1000 Subject: [PATCH] spec: fix crashReporter upload assertions --- spec/api-crash-reporter-spec.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/spec/api-crash-reporter-spec.js b/spec/api-crash-reporter-spec.js index 92be8b426283..bd6ec6e29a9d 100644 --- a/spec/api-crash-reporter-spec.js +++ b/spec/api-crash-reporter-spec.js @@ -425,16 +425,16 @@ const startServer = ({ callback, processType, done }) => { if (error) throw error if (called) return called = true - assert.strictEqual(fields.prod, 'Electron') - assert.strictEqual(fields.ver, process.versions.electron) - assert.strictEqual(fields.process_type, processType) - assert.strictEqual(fields.platform, process.platform) - assert.strictEqual(fields.extra1, 'extra1') - assert.strictEqual(fields.extra2, 'extra2') + assert.deepStrictEqual(String(fields.prod), 'Electron') + assert.strictEqual(String(fields.ver), process.versions.electron) + assert.strictEqual(String(fields.process_type), processType) + assert.strictEqual(String(fields.platform), process.platform) + assert.strictEqual(String(fields.extra1), 'extra1') + assert.strictEqual(String(fields.extra2), 'extra2') assert.strictEqual(fields.extra3, undefined) - assert.strictEqual(fields._productName, 'Zombies') - assert.strictEqual(fields._companyName, 'Umbrella Corporation') - assert.strictEqual(fields._version, app.getVersion()) + assert.strictEqual(String(fields._productName), 'Zombies') + assert.strictEqual(String(fields._companyName), 'Umbrella Corporation') + assert.strictEqual(String(fields._version), app.getVersion()) const reportId = 'abc-123-def-456-abc-789-abc-123-abcd' res.end(reportId, () => {