From db84f39e5e4718f7bc9b9bc94c4028bcd47189d6 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Wed, 22 Jan 2025 10:11:19 +0100 Subject: [PATCH] refactor: simplify `ParseUserScript()` (#45289) refactor: simplify ParseUserScript() local variable user_script no longer needed after #43205 Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr --- .../browser/extensions/api/scripting/scripting_api.cc | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/shell/browser/extensions/api/scripting/scripting_api.cc b/shell/browser/extensions/api/scripting/scripting_api.cc index 4745cc874b4..448cb8aae20 100644 --- a/shell/browser/extensions/api/scripting/scripting_api.cc +++ b/shell/browser/extensions/api/scripting/scripting_api.cc @@ -490,14 +490,8 @@ std::unique_ptr ParseUserScript( ConvertRegisteredContentScriptToSerializedUserScript( std::move(content_script)); - std::unique_ptr user_script = - script_serialization::ParseSerializedUserScript( - serialized_script, extension, allowed_in_incognito, error); - if (!user_script) { - return nullptr; // Parsing failed. - } - - return user_script; + return script_serialization::ParseSerializedUserScript( + serialized_script, extension, allowed_in_incognito, error); } // Converts a UserScript object to a api::scripting::RegisteredContentScript