mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test: spellchecker may take several minutes to load under ASan (#28230)

Browse source 
* test: spellchecker may take several minutes to load under ASan

* Add TODO for the timeout
This commit is contained in:
Cheng Zhao 2021-03-22 10:56:08 +09:00 committed by GitHub
parent a79ef2d525
commit db7059eb0a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
spec-main/spellchecker-spec.ts
View file

@ -10,7 +10,9 @@ const features = process._linkedBinding('electron_common_features');
const v8Util = process._linkedBinding('electron_common_v8_util');
ifdescribe(features.isBuiltinSpellCheckerEnabled())('spellchecker', function () {
this.timeout(200 * 1000);
// TODO(zcbenz): Spellchecker loads really slow on ASan, we should provide
// a small testing dictionary to make the tests load faster.
this.timeout((process.env.IS_ASAN ? 700 : 20) * 1000);
let w: BrowserWindow;
@ -30,7 +32,7 @@ ifdescribe(features.isBuiltinSpellCheckerEnabled())('spellchecker', function ()
// to detect spellchecker is to keep checking with a busy loop.
async function rightClickUntil (fn: (params: Electron.ContextMenuParams) => boolean) {
const now = Date.now();
const timeout = (process.env.IS_ASAN ? 180 : 10) * 1000;
const timeout = (process.env.IS_ASAN ? 600 : 10) * 1000;
let contextMenuParams = await rightClick();
while (!fn(contextMenuParams) && (Date.now() - now < timeout)) {
await delay(100);