mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: throw error when inserting menu items out-of-range (#17401)

Browse source 
* fix: throw error when inserting menu items out-of-range

* also check pos < 0
This commit is contained in:
Shelley Vohr 2019-03-18 07:58:42 -07:00 • committed by GitHub
parent f09f43a4a9
commit db29978fe0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spec/api-menu-spec.js
View file

@ -688,6 +688,24 @@ describe('Menu module', () => {
})
describe('Menu.insert', () => {
it('should throw when attempting to insert at out-of-range indices', () => {
const menu = Menu.buildFromTemplate([
{ label: '1' },
{ label: '2' },
{ label: '3' }
])
const item = new MenuItem({ label: 'badInsert' })
expect(() => {
menu.insert(9999, item)
}).to.throw(/Position 9999 cannot be greater than the total MenuItem count/)
expect(() => {
menu.insert(-9999, item)
}).to.throw(/Position -9999 cannot be less than 0/)
})
it('should store item in @items by its index', () => {
const menu = Menu.buildFromTemplate([
{ label: '1' },