mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: throw error when inserting menu items out-of-range (#17401)

Browse source 
* fix: throw error when inserting menu items out-of-range

* also check pos < 0
This commit is contained in:
Shelley Vohr 2019-03-18 07:58:42 -07:00 • committed by GitHub
parent f09f43a4a9
commit db29978fe0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/browser/api/menu.js
View file

@ -110,6 +110,12 @@ Menu.prototype.insert = function (pos, item) {
throw new TypeError('Invalid item')
}
if (pos < 0) {
throw new RangeError(`Position ${pos} cannot be less than 0`)
} else if (pos > this.getItemCount()) {
throw new RangeError(`Position ${pos} cannot be greater than the total MenuItem count`)
}
// insert item depending on its type
insertItemByType.call(this, item, pos)