mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: use a WeakPtr so we do not UAF the store in FunctionLifetimeMonitor (#22056)

Browse source
This commit is contained in:
Samuel Attard 2020-02-08 20:49:38 -08:00 • committed by GitHub
parent 43592f8b71
commit dafbf04b9a
2 changed files with 21 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/renderer/api/context_bridge/render_frame_context_bridge_store.h
View file

@ -50,6 +50,10 @@ class RenderFramePersistenceStore final : public content::RenderFrameObserver {
v8::Local<v8::Value> proxy_value);
v8::MaybeLocal<v8::Value> GetCachedProxiedObject(v8::Local<v8::Value> from);
base::WeakPtr<RenderFramePersistenceStore> GetWeakPtr() {
return weak_factory_.GetWeakPtr();
}
private:
// func_id ==> { function, owning_context }
std::map<size_t, FunctionContextPair> functions_;