mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

refactor: invoke loadURL in SrcAttribute instead of sending IPC directly (#29031)

Browse source
This commit is contained in:
Milan Burda 2021-05-06 22:55:32 +02:00 committed by GitHub
parent ad4def9af7
commit dab9a88413
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/renderer/web-view/web-view-attributes.ts
View file

@ -1,7 +1,5 @@
import { ipcRendererInternal } from '@electron/internal/renderer/ipc-renderer-internal';
import { WebViewImpl } from '@electron/internal/renderer/web-view/web-view-impl'; import { WebViewImpl } from '@electron/internal/renderer/web-view/web-view-impl';
import { WEB_VIEW_CONSTANTS } from '@electron/internal/renderer/web-view/web-view-constants'; import { WEB_VIEW_CONSTANTS } from '@electron/internal/renderer/web-view/web-view-constants';
import { IPC_MESSAGES } from '@electron/internal/common/ipc-messages';
const resolveURL = function (url?: string | null) { const resolveURL = function (url?: string | null) {
return url ? new URL(url, location.href).href : ''; return url ? new URL(url, location.href).href : '';
@ -188,11 +186,7 @@ export class SrcAttribute extends WebViewAttribute {
opts.userAgent = useragent; opts.userAgent = useragent;
} }
const guestInstanceId = this.webViewImpl.guestInstanceId; (this.webViewImpl.webviewNode as Electron.WebviewTag).loadURL(this.getValue(), opts);
const method = 'loadURL';
const args = [this.getValue(), opts];
ipcRendererInternal.invoke(IPC_MESSAGES.GUEST_VIEW_MANAGER_CALL, guestInstanceId, method, args);
} }
} }