From da92abf96498d3edf7c25caf1d814f0fc6ea4f54 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Fri, 13 Jul 2018 14:42:36 -0500 Subject: [PATCH] document ELECTRON_S3_ tokens --- docs/development/releasing.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/development/releasing.md b/docs/development/releasing.md index dfb1bdbd63ec..d992491862e6 100644 --- a/docs/development/releasing.md +++ b/docs/development/releasing.md @@ -21,6 +21,10 @@ Create a token from "Personal API Tokens" at https://circleci.com/account/api * `VSTS_TOKEN`: Create a Personal Access Token at https://github.visualstudio.com/_details/security/tokens with the scope of `Build (read and execute)`. +* `ELECTRON_S3_BUCKET`: +* `ELECTRON_S3_ACCESS_KEY`: +* `ELECTRON_S3_SECRET_KEY`: +If you don't have these, ask a team member to help you. ## Determine which branch to release from @@ -205,7 +209,7 @@ release notes. $ npm run release -- --validateRelease ``` Note, if you need to run `--validateRelease` more than once to check the assets, -run it as above the first time, then `node ./script/release.js --validateRelase` +run it as above the first time, then `node ./script/release.js --validateRelease` for subsequent calls so that you don't have to rebuild each time you want to check the assets.