mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Don't leak listeners in embedder when guest is destroyed

Browse source
This commit is contained in:
Cheng Zhao 2014-12-17 20:44:15 -08:00
parent a26091e485
commit da54ac5f55
3 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/lib/guest-view-manager.coffee
View file

@ -40,9 +40,9 @@ createGuest = (embedder, params) ->
destroyEvents = ['destroyed', 'crashed', 'did-navigate-to-different-page']
destroy = ->
destroyGuest id if guestInstances[id]?
embedder.removeListener event, destroy for event in destroyEvents
embedder.setMaxListeners 100 # we can have lots of <webview> in one page.
embedder.once event, destroy for event in destroyEvents
guest.once 'destroyed', ->
embedder.removeListener event, destroy for event in destroyEvents
# Init guest web view after attached.
guest.once 'did-attach', ->