mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: return early on promise rejection (#26095)

Browse source
This commit is contained in:
David Sanders 2020-10-22 10:53:42 -07:00 • committed by GitHub
parent c934d1386b
commit d9db9873fd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/api/electron_api_session.cc
View file

@ -978,9 +978,11 @@ v8::Local<v8::Promise> Session::ListWordsInSpellCheckerDictionary() {
SpellcheckService* spellcheck = SpellcheckService* spellcheck =
SpellcheckServiceFactory::GetForContext(browser_context_); SpellcheckServiceFactory::GetForContext(browser_context_);
if (!spellcheck) if (!spellcheck) {
promise.RejectWithErrorMessage( promise.RejectWithErrorMessage(
"Spellcheck in unexpected state: failed to load custom dictionary."); "Spellcheck in unexpected state: failed to load custom dictionary.");
return handle;
}
if (spellcheck->GetCustomDictionary()->IsLoaded()) { if (spellcheck->GetCustomDictionary()->IsLoaded()) {
promise.Resolve(spellcheck->GetCustomDictionary()->GetWords()); promise.Resolve(spellcheck->GetCustomDictionary()->GetWords());