From d9a7fee79a96715493b0da5a27964c13041441ff Mon Sep 17 00:00:00 2001
From: Jacob Groundwater <groundwater@github.com>
Date: Wed, 29 Aug 2018 10:31:45 -0700
Subject: [PATCH] feat: Add electron version to framework (#14296)

* Add electron version to framework

* Update Info.plist
---
 BUILD.gn                             | 2 +-
 atom/common/resources/mac/Info.plist | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/BUILD.gn b/BUILD.gn
index 5fc1bbbf99d1..8182c64d1a9d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -526,7 +526,7 @@ if (is_mac) {
       deps += [ ":electron_crashpad_helper" ]
     }
     info_plist = "atom/common/resources/mac/Info.plist"
-    extra_substitutions = [ "ATOM_BUNDLE_ID=$electron_mac_bundle_id.framework" ]
+    extra_substitutions = [ "ATOM_BUNDLE_ID=$electron_mac_bundle_id.framework", "ELECTRON_VERSION=$electron_version" ]
 
     include_dirs = [ "." ]
     sources = filenames_gypi.framework_sources
diff --git a/atom/common/resources/mac/Info.plist b/atom/common/resources/mac/Info.plist
index 7b56a46470ea..26abfe04ca89 100644
--- a/atom/common/resources/mac/Info.plist
+++ b/atom/common/resources/mac/Info.plist
@@ -12,5 +12,7 @@
 	<string>FMWK</string>
 	<key>NSSupportsAutomaticGraphicsSwitching</key>
 	<true/>
+	<key>CFBundleVersion</key>
+	<string>${ELECTRON_VERSION}</string>
 </dict>
 </plist>