mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Set _debugWaitConnect on --inspect-brk

Browse source
This commit is contained in:
Kevin Sawicki 2017-05-16 14:50:49 -07:00
parent c419ebdd6d
commit d8aca08da7
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
atom/browser/node_debugger.cc
View file

@ -7,6 +7,7 @@
#include "base/command_line.h" #include "base/command_line.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "libplatform/libplatform.h" #include "libplatform/libplatform.h"
#include "native_mate/dictionary.h"
namespace atom { namespace atom {
@ -35,6 +36,13 @@ void NodeDebugger::Start() {
// with node's inspector agent // with node's inspector agent
platform_.reset(v8::platform::CreateDefaultPlatform()); platform_.reset(v8::platform::CreateDefaultPlatform());
// Set process._debugWaitConnect if --inspect-brk was specified to stop
// the debugger on the first line
if (options.wait_for_connect()) {
mate::Dictionary process(env_->isolate(), env_->process_object());
process.Set("_debugWaitConnect", true);
}
inspector->Start(platform_.get(), nullptr, options); inspector->Start(platform_.get(), nullptr, options);
} }
} }

6
atom/common/node_bindings.cc
View file

@ -198,12 +198,6 @@ node::Environment* NodeBindings::CreateEnvironment(
PathService::Get(content::CHILD_PROCESS_EXE, &helper_exec_path); PathService::Get(content::CHILD_PROCESS_EXE, &helper_exec_path);
process.Set("helperExecPath", helper_exec_path); process.Set("helperExecPath", helper_exec_path);
// Set process._debugWaitConnect if --debug-brk was specified to stop
// the debugger on the first line
if (browser_env_ == BROWSER &&
base::CommandLine::ForCurrentProcess()->HasSwitch("debug-brk"))
process.Set("_debugWaitConnect", true);
return env; return env;
} }