mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: reloadIgnoringCache() should ignore the cache (#21263)

Browse source
This commit is contained in:
Samuel Attard 2019-11-25 11:12:58 -08:00 • committed by GitHub
parent f26b7931eb
commit d84ba30541
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
lib/browser/navigation-controller.js
View file

@ -152,7 +152,8 @@ const NavigationController = (function () {
NavigationController.prototype.reloadIgnoringCache = function () { NavigationController.prototype.reloadIgnoringCache = function () {
this.pendingIndex = this.currentIndex this.pendingIndex = this.currentIndex
return this.webContents._loadURL(this.getURL(), { return this.webContents._loadURL(this.getURL(), {
extraHeaders: 'pragma: no-cache\n' extraHeaders: 'pragma: no-cache\n',
reloadIgnoringCache: true
}) })
} }

6
shell/browser/api/atom_api_web_contents.cc
View file

@ -1383,6 +1383,12 @@ void WebContents::LoadURL(const GURL& url,
params.load_type = content::NavigationController::LOAD_TYPE_DATA; params.load_type = content::NavigationController::LOAD_TYPE_DATA;
} }
bool reload_ignoring_cache = false;
if (options.Get("reloadIgnoringCache", &reload_ignoring_cache) &&
reload_ignoring_cache) {
params.reload_type = content::ReloadType::BYPASSING_CACHE;
}
// Calling LoadURLWithParams() can trigger JS which destroys |this|. // Calling LoadURLWithParams() can trigger JS which destroys |this|.
auto weak_this = GetWeakPtr(); auto weak_this = GetWeakPtr();