mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: use consistent parameter names (#26162)

Browse source
This commit is contained in:
David Sanders 2020-10-27 08:18:36 -07:00 • committed by GitHub
parent 52fd855ad4
commit d8167ce138
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 20 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/api/electron_api_notification.h
View file

@ -90,7 +90,7 @@ class Notification : public gin::Wrappable<Notification>,
void SetSound(const base::string16& sound);
void SetActions(const std::vector<electron::NotificationAction>& actions);
void SetCloseButtonText(const base::string16& text);
void SetToastXml(const base::string16& text);
void SetToastXml(const base::string16& new_toast_xml);
private:
base::string16 title_;

2
shell/browser/api/electron_api_url_loader.h
View file

@ -63,7 +63,7 @@ class SimpleURLLoaderWrapper
const char* GetTypeName() override;
private:
SimpleURLLoaderWrapper(std::unique_ptr<network::ResourceRequest> loader,
SimpleURLLoaderWrapper(std::unique_ptr<network::ResourceRequest> request,
network::mojom::URLLoaderFactory* url_loader_factory,
int options);

4
shell/browser/api/electron_api_view.h
View file

@ -25,8 +25,8 @@ class View : public gin_helper::Wrappable<View> {
v8::Local<v8::FunctionTemplate> prototype);
#if BUILDFLAG(ENABLE_VIEWS_API)
void AddChildView(gin::Handle<View> view);
void AddChildViewAt(gin::Handle<View> view, size_t index);
void AddChildView(gin::Handle<View> child);
void AddChildViewAt(gin::Handle<View> child, size_t index);
#endif
views::View* view() const { return view_; }

2
shell/browser/api/message_port.h
View file

@ -32,7 +32,7 @@ class MessagePort : public gin::Wrappable<MessagePort>, mojo::MessageReceiver {
void Start();
void Close();
void Entangle(blink::MessagePortDescriptor handle);
void Entangle(blink::MessagePortDescriptor port);
void Entangle(blink::MessagePortChannel channel);
blink::MessagePortChannel Disentangle();