From d79ebc6dc6cb1a39435c3f07ef52bd8c501c629c Mon Sep 17 00:00:00 2001
From: John Kleinschmidt <jkleinsc@electronjs.org>
Date: Wed, 19 May 2021 19:08:24 -0400
Subject: [PATCH] fix: pdf viewer permissions (#29210)

* fix: pdf viewer permissions

* fixup for getAllExtensions
---
 shell/browser/api/electron_api_session.cc             | 2 +-
 shell/browser/extensions/electron_extension_system.cc | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/shell/browser/api/electron_api_session.cc b/shell/browser/api/electron_api_session.cc
index 74d8f796fa0c..2940dd832420 100644
--- a/shell/browser/api/electron_api_session.cc
+++ b/shell/browser/api/electron_api_session.cc
@@ -851,7 +851,7 @@ v8::Local<v8::Value> Session::GetAllExtensions() {
   std::vector<const extensions::Extension*> extensions_vector;
   for (const auto& extension : *installed_extensions) {
     if (extension->location() !=
-        extensions::mojom::ManifestLocation::kExternalComponent)
+        extensions::mojom::ManifestLocation::kComponent)
       extensions_vector.emplace_back(extension.get());
   }
   return gin::ConvertToV8(isolate_, extensions_vector);
diff --git a/shell/browser/extensions/electron_extension_system.cc b/shell/browser/extensions/electron_extension_system.cc
index 5e2ea344dda6..66ed510bd8fe 100644
--- a/shell/browser/extensions/electron_extension_system.cc
+++ b/shell/browser/extensions/electron_extension_system.cc
@@ -119,8 +119,7 @@ void ElectronExtensionSystem::LoadComponentExtensions() {
     root_directory = root_directory.Append(FILE_PATH_LITERAL("pdf"));
     scoped_refptr<const Extension> pdf_extension =
         extensions::Extension::Create(
-            root_directory,
-            extensions::mojom::ManifestLocation::kExternalComponent,
+            root_directory, extensions::mojom::ManifestLocation::kComponent,
             *pdf_manifest, extensions::Extension::REQUIRE_KEY, &utf8_error);
     extension_loader_->registrar()->AddExtension(pdf_extension);
   }