feat: add webUtils module with getPathForFile method (#38776)

* feat: add blinkUtils module with getPathForFile method This is designed to replace the File.path augmentation we currently have in place to allow apps to get the filesystem path for a file that blink has a representation of. File.path is non-standard and messes with certain websites, using a method like this is effectively 0-cost and removes one of the final deviations we have with web standards. * add error * refactor: update per PR feedback * chore: update patches * oops * chore: update patches * chore: update patches * feat: add blinkUtils module with getPathForFile method This is designed to replace the File.path augmentation we currently have in place to allow apps to get the filesystem path for a file that blink has a representation of. File.path is non-standard and messes with certain websites, using a method like this is effectively 0-cost and removes one of the final deviations we have with web standards. * add error * refactor: update per PR feedback * chore: update patches * oops * chore: update patches * chore: update patches * chore: update patches * fix: provide isolate to WebBlob::FromV8Value * chore: add tests * build: fix depshash mismatch on arm64 macOS --------- Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
2023-11-20 15:59:36 -08:00 · 2023-11-20 15:59:36 -08:00 · d6bb9b40b0
commit d6bb9b40b0
parent 2c03b8fd6b
16 changed files with 211 additions and 4 deletions
--- a/spec/api-web-utils-spec.ts
+++ b/spec/api-web-utils-spec.ts
@ -0,0 +1,53 @@
+import { expect } from 'chai';
+import * as path from 'node:path';
+import { BrowserWindow } from 'electron/main';
+import { defer } from './lib/spec-helpers';
+// import { once } from 'node:events';
+
+describe('webUtils module', () => {
+  const fixtures = path.resolve(__dirname, 'fixtures');
+
+  describe('getPathForFile', () => {
+    it('returns nothing for a Blob', async () => {
+      const w = new BrowserWindow({
+        show: false,
+        webPreferences: {
+          contextIsolation: false,
+          nodeIntegration: true,
+          sandbox: false
+        }
+      });
+      defer(() => w.close());
+      await w.loadFile(path.resolve(fixtures, 'pages', 'file-input.html'));
+      const pathFromWebUtils = await w.webContents.executeJavaScript('require("electron").webUtils.getPathForFile(new Blob([1, 2, 3]))');
+      expect(pathFromWebUtils).to.equal('');
+    });
+
+    it('reports the correct path for a File object', async () => {
+      const w = new BrowserWindow({
+        show: false,
+        webPreferences: {
+          contextIsolation: false,
+          nodeIntegration: true,
+          sandbox: false
+        }
+      });
+      defer(() => w.close());
+      await w.loadFile(path.resolve(fixtures, 'pages', 'file-input.html'));
+      const { debugger: debug } = w.webContents;
+      debug.attach();
+      try {
+        const { root: { nodeId } } = await debug.sendCommand('DOM.getDocument');
+        const { nodeId: inputNodeId } = await debug.sendCommand('DOM.querySelector', { nodeId, selector: 'input' });
+        await debug.sendCommand('DOM.setFileInputFiles', {
+          files: [__filename],
+          nodeId: inputNodeId
+        });
+        const pathFromWebUtils = await w.webContents.executeJavaScript('require("electron").webUtils.getPathForFile(document.querySelector("input").files[0])');
+        expect(pathFromWebUtils).to.equal(__filename);
+      } finally {
+        debug.detach();
+      }
+    });
+  });
+});