mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: add webUtils module with getPathForFile method (#38776)

Browse source 
* feat: add blinkUtils module with getPathForFile method

This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.

File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.

* add error

* refactor: update per PR feedback

* chore: update patches

* oops

* chore: update patches

* chore: update patches

* feat: add blinkUtils module with getPathForFile method

This is designed to replace the File.path augmentation
we currently have in place to allow apps to get the filesystem
path for a file that blink has a representation of.

File.path is non-standard and messes with certain websites, using
a method like this is effectively 0-cost and removes one of the final
deviations we have with web standards.

* add error

* refactor: update per PR feedback

* chore: update patches

* oops

* chore: update patches

* chore: update patches

* chore: update patches

* fix: provide isolate to WebBlob::FromV8Value

* chore: add tests

* build: fix depshash mismatch on arm64 macOS

---------

Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
This commit is contained in:
Samuel Attard 2023-11-20 15:59:36 -08:00 • committed by GitHub
parent 2c03b8fd6b
commit d6bb9b40b0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 211 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

16
shell/renderer/api/electron_api_web_utils.h Normal file
View file

@ -0,0 +1,16 @@
// Copyright (c) 2023 Salesforce, Inc.
// Use of this source code is governed by the MIT license that can be
// found in the LICENSE file.
#ifndef ELECTRON_SHELL_RENDERER_API_ELECTRON_API_WEB_UTILS_H_
#define ELECTRON_SHELL_RENDERER_API_ELECTRON_API_WEB_UTILS_H_
#include "v8/include/v8.h"
namespace electron::api::web_utils {
std::string GetPathForFile(v8::Isolate* isolate, v8::Local<v8::Value> file);
} // namespace electron::api::web_utils
#endif // ELECTRON_SHELL_RENDERER_API_ELECTRON_API_WEB_UTILS_H_