mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: fix more chromium-style errors in windows code (#13487)

Browse source 
Finding more chromium-style linting errors as I build more of the windows code :)
This commit is contained in:
Jeremy Apthorp 2018-06-28 14:20:11 -07:00 • committed by GitHub
parent 003a92e099
commit d6af3bfcd2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 23 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

8
atom/common/promise_util.cc
View file

@ -10,6 +10,14 @@ namespace atom {
namespace util {
Promise::Promise(v8::Isolate* isolate) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
isolate_ = isolate;
resolver_.Reset(isolate, v8::Promise::Resolver::New(isolate));
}
Promise::~Promise() = default;
v8::Maybe<bool> Promise::RejectWithErrorMessage(const std::string& string) {
v8::Local<v8::String> error_message =
v8::String::NewFromUtf8(isolate(), string.c_str());