mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: fix gn cpplint warnings (#14583)

Browse source 
* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again
This commit is contained in:
Charles Kerr 2018-09-12 19:25:56 -05:00 • committed by GitHub
parent 183a043216
commit d663b4eaee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
120 changed files with 204 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

1
atom/renderer/api/atom_api_spell_check_client.h
View file

@ -5,6 +5,7 @@
#ifndef ATOM_RENDERER_API_ATOM_API_SPELL_CHECK_CLIENT_H_
#define ATOM_RENDERER_API_ATOM_API_SPELL_CHECK_CLIENT_H_
#include <memory>
#include <string>
#include <vector>

1
atom/renderer/atom_renderer_client.h
View file

@ -5,6 +5,7 @@
#ifndef ATOM_RENDERER_ATOM_RENDERER_CLIENT_H_
#define ATOM_RENDERER_ATOM_RENDERER_CLIENT_H_
#include <memory>
#include <set>
#include <string>
#include <vector>

4
atom/renderer/atom_sandboxed_renderer_client.cc
View file

@ -30,8 +30,8 @@ namespace atom {
namespace {
const std::string kIpcKey = "ipcNative";
const std::string kModuleCacheKey = "native-module-cache";
const char kIpcKey[] = "ipcNative";
const char kModuleCacheKey[] = "native-module-cache";
bool IsDevTools(content::RenderFrame* render_frame) {
return render_frame->GetWebFrame()->GetDocument().Url().ProtocolIs(

1
atom/renderer/atom_sandboxed_renderer_client.h
View file

@ -4,6 +4,7 @@
#ifndef ATOM_RENDERER_ATOM_SANDBOXED_RENDERER_CLIENT_H_
#define ATOM_RENDERER_ATOM_SANDBOXED_RENDERER_CLIENT_H_
#include <memory>
#include <string>
#include <vector>

1
atom/renderer/guest_view_container.cc
View file

@ -5,6 +5,7 @@
#include "atom/renderer/guest_view_container.h"
#include <map>
#include <utility>
#include "base/bind.h"
#include "base/lazy_instance.h"

1
atom/renderer/renderer_client_base.cc
View file

@ -4,6 +4,7 @@
#include "atom/renderer/renderer_client_base.h"
#include <memory>
#include <string>
#include <vector>

1
atom/renderer/renderer_client_base.h
View file

@ -5,6 +5,7 @@
#ifndef ATOM_RENDERER_RENDERER_CLIENT_BASE_H_
#define ATOM_RENDERER_RENDERER_CLIENT_BASE_H_
#include <memory>
#include <string>
#include <vector>

2
atom/renderer/web_worker_observer.h
View file

@ -5,6 +5,8 @@
#ifndef ATOM_RENDERER_WEB_WORKER_OBSERVER_H_
#define ATOM_RENDERER_WEB_WORKER_OBSERVER_H_
#include <memory>
#include "base/macros.h"
#include "v8/include/v8.h"