fix: fix gn cpplint warnings (#14583)

* chore: fix cpplint 'include_what_you_use' warnings

Typically by including <memory>, <utility> etc.

* chore: fix 'static/global string constant' warning

Use C style strings instead of std::string.

Style guide forbids non-trivial static / global variables. https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

/home/charles/electron/electron-gn/src/electron/script/cpplint.js

* refactor: remove global string variables.

Fix 'global string variables are not permitted' linter warnings
by using the base::NoDestructor<> wrapper to make it explicit that
these variables are never destroyed.

The style guide's take on globals with nontrivial destructors:
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables

* fix: initializer error introduced in last commit

* fix: remove WIP file that was included by accident

* fix: include order

* fix: include order

* fix: include order

* fix: include order, again

atom/browser/ui/tray_icon_gtk.h

@@ -5,6 +5,7 @@
 #ifndef ATOM_BROWSER_UI_TRAY_ICON_GTK_H_
 #define ATOM_BROWSER_UI_TRAY_ICON_GTK_H_
 
+#include <memory>
 #include <string>
 
 #include "atom/browser/ui/tray_icon.h"

atom/browser/ui/views/autofill_popup_view.cc

@@ -3,6 +3,9 @@
 // found in the LICENSE file.
 
 #include "atom/browser/ui/views/autofill_popup_view.h"
+
+#include <memory>
+
 #include "base/bind.h"
 #include "base/i18n/rtl.h"
 #include "cc/paint/skia_paint_canvas.h"

atom/browser/ui/views/autofill_popup_view.h

@@ -5,6 +5,8 @@
 #ifndef ATOM_BROWSER_UI_VIEWS_AUTOFILL_POPUP_VIEW_H_
 #define ATOM_BROWSER_UI_VIEWS_AUTOFILL_POPUP_VIEW_H_
 
+#include <memory>
+
 #include "atom/browser/ui/autofill_popup.h"
 
 #if defined(ENABLE_OSR)

atom/browser/ui/views/menu_bar.cc

@@ -4,6 +4,8 @@
 
 #include "atom/browser/ui/views/menu_bar.h"
 
+#include <memory>
+
 #include "atom/browser/ui/views/menu_delegate.h"
 #include "atom/browser/ui/views/submenu_button.h"
 #include "ui/base/models/menu_model.h"

atom/browser/ui/views/submenu_button.cc

@@ -4,6 +4,9 @@
 
 #include "atom/browser/ui/views/submenu_button.h"
 
+#include <memory>
+#include <utility>
+
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "ui/gfx/canvas.h"

atom/browser/ui/views/submenu_button.h

@@ -5,6 +5,8 @@
 #ifndef ATOM_BROWSER_UI_VIEWS_SUBMENU_BUTTON_H_
 #define ATOM_BROWSER_UI_VIEWS_SUBMENU_BUTTON_H_
 
+#include <memory>
+
 #include "ui/views/animation/ink_drop_highlight.h"
 #include "ui/views/controls/button/menu_button.h"
 

atom/browser/ui/webui/pdf_viewer_handler.cc

@@ -4,6 +4,9 @@
 
 #include "atom/browser/ui/webui/pdf_viewer_handler.h"
 
+#include <memory>
+#include <utility>
+
 #include "atom/common/atom_constants.h"
 #include "base/bind.h"
 #include "base/values.h"

atom/browser/ui/webui/pdf_viewer_handler.h

@@ -9,6 +9,7 @@
 #error("This header can only be used when enable_pdf_viewer gyp flag is enabled")  // NOLINT
 #endif  // defined(ENABLE_PDF_VIEWER)
 
+#include <memory>
 #include <string>
 
 #include "atom/browser/web_contents_zoom_controller.h"

atom/browser/ui/webui/pdf_viewer_ui.cc

@@ -5,6 +5,8 @@
 #include "atom/browser/ui/webui/pdf_viewer_ui.h"
 
 #include <map>
+#include <memory>
+#include <utility>
 
 #include "atom/browser/atom_browser_context.h"
 #include "atom/browser/loader/layered_resource_handler.h"

atom/browser/ui/webui/pdf_viewer_ui.h

@@ -9,6 +9,7 @@
 #error("This header can only be used when enable_pdf_viewer gyp flag is enabled")  // NOLINT
 #endif  // defined(ENABLE_PDF_VIEWER)
 
+#include <memory>
 #include <string>
 
 #include "base/macros.h"

atom/browser/ui/win/notify_icon.h

@@ -9,6 +9,7 @@
 
 #include <shellapi.h>
 
+#include <memory>
 #include <string>
 
 #include "atom/browser/ui/tray_icon.h"

atom/browser/ui/x/event_disabler.cc

@@ -4,6 +4,8 @@
 
 #include "atom/browser/ui/x/event_disabler.h"
 
+#include <memory>
+
 namespace atom {
 
 EventDisabler::EventDisabler() {}

atom/browser/ui/x/event_disabler.h

@@ -5,6 +5,8 @@
 #ifndef ATOM_BROWSER_UI_X_EVENT_DISABLER_H_
 #define ATOM_BROWSER_UI_X_EVENT_DISABLER_H_
 
+#include <memory>
+
 #include "base/macros.h"
 #include "ui/events/event_rewriter.h"
 

atom/browser/ui/x/x_window_utils.cc

@@ -5,6 +5,7 @@
 #include "atom/browser/ui/x/x_window_utils.h"
 
 #include <X11/Xatom.h>
+#include <memory>
 
 #include "base/environment.h"
 #include "base/strings/string_util.h"