mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

update a few steps in upgrading-node.md

Browse source
This commit is contained in:
Shelley Vohr 2017-12-12 22:55:37 -05:00
parent 5720a8e7d5
commit d602a30bbc
No known key found for this signature in database
GPG key ID: F13993A75599653C
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
docs/development/upgrading-node.md
View file

@ -38,7 +38,8 @@ So in short, the primary steps are:
## Updating Electron's Node [fork](https://github.com/electron/node) ## Updating Electron's Node [fork](https://github.com/electron/node)
1. Create a branch in https://github.com/electron/node: `electron-node-vX.X.X` 1. Ensure that `master` on `electron/node` has updated release tags from `nodejs/node`
1. Create a branch in https://github.com/electron/node: `electron-node-vX.X.X` where the base that you're branching from is the tag for the desired update
- `vX.X.X` Must use a version of node compatible with our current version of chromium - `vX.X.X` Must use a version of node compatible with our current version of chromium
2. Re-apply our commits from the previous version of node we were using (`vY.Y.Y`) to `v.X.X.X` 2. Re-apply our commits from the previous version of node we were using (`vY.Y.Y`) to `v.X.X.X`
- Check release tag and select the range of commits we need to re-apply - Check release tag and select the range of commits we need to re-apply