From d5c658545ac8580cf5e64790a506f615adf5cd18 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Thu, 11 Jan 2024 01:13:36 +1300 Subject: [PATCH] chore: fix content tracing flake (#40939) * chore: fix contentTracing test * cry --- .circleci/config/base.yml | 3 +++ spec/api-content-tracing-spec.ts | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.circleci/config/base.yml b/.circleci/config/base.yml index 651320687a75..c29c61381ebf 100644 --- a/.circleci/config/base.yml +++ b/.circleci/config/base.yml @@ -1631,6 +1631,9 @@ commands: echo "Piping output to ASAN_SYMBOLIZE ($ASAN_SYMBOLIZE)" (cd electron && (circleci tests glob "spec/*-spec.ts" | xargs -I@ -P4 bash -c "echo $(pwd)/@" | circleci tests run --command="xargs node script/yarn test --runners=main --trace-uncaught --enable-logging --files" --split-by=timings 2>&1)) | $ASAN_SYMBOLIZE else + if [ "$TARGET_ARCH" == "arm" ] || [ "$TARGET_ARCH" == "arm64" ]; then + export ELECTRON_SKIP_NATIVE_MODULE_TESTS=true + fi if [ "$TARGET_ARCH" == "ia32" ]; then npm_config_arch=x64 node electron/node_modules/dugite/script/download-git.js fi diff --git a/spec/api-content-tracing-spec.ts b/spec/api-content-tracing-spec.ts index dbf6b025e8ab..98c34a4c8ac1 100644 --- a/spec/api-content-tracing-spec.ts +++ b/spec/api-content-tracing-spec.ts @@ -73,7 +73,7 @@ ifdescribe(!(['arm', 'arm64'].includes(process.arch)) || (process.platform !== ' // If the `categoryFilter` param above is not respected // the file size will be above 50KB. const fileSizeInKiloBytes = getFileSizeInKiloBytes(outputFilePath); - const expectedMaximumFileSize = 10; // Depends on a platform. + const expectedMaximumFileSize = 50; // Depends on a platform. expect(fileSizeInKiloBytes).to.be.above(0, `the trace output file is empty, check "${outputFilePath}"`);